Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CorsFetch on CommonWV.py sends multiple license requests with different origin header #26

Closed
ElCap13 opened this issue Jun 10, 2024 · 1 comment
Labels
bug Something isn't working completed good first issue Good for newcomers

Comments

@ElCap13
Copy link
Contributor

ElCap13 commented Jun 10, 2024

since CommonWV.py has been changed to CorsFetch, ive noticed that there are multiple license requests being sent.
eg. using https://bitmovin.com/demos/drm
there are 3 license requests being sent, 2 of them with this header
"Origin: https://js.driftt.com"
and one with (the correct one):
"Origin: https://bitmovin.com"

i tried it on a different site and it sent 5 license requests.
it seems to send a license request for every different domain thats in the cookies storage

@FoxRefire
Copy link
Owner

FoxRefire commented Jun 10, 2024

Thanks for reporting this issue.

The problem is caused by specifying the destination of the content script that sends the FETCH message in an imprecise manner: the URL of the tab.

When there are multiple frames in the target tab, FETCH messages are being sent to all content scripts running in the frames.

This also causes problems like #13 (comment).

It must be changed to determine the target content script in a more accurate manner.

This will be corrected later in my spare time.

@FoxRefire FoxRefire added good first issue Good for newcomers bug Something isn't working completed labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working completed good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants