Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "email" link to sharing options #28

Open
e-t-k opened this issue May 23, 2016 · 1 comment
Open

Add "email" link to sharing options #28

e-t-k opened this issue May 23, 2016 · 1 comment

Comments

@e-t-k
Copy link
Contributor

e-t-k commented May 23, 2016

Current "sharing" dialog should have am "email" option added.
Would open the user's chosen mail client and generate an email with any images in the post embedded as attachments.

screen shot 2016-05-23 at 11 08 30 am

@e-t-k
Copy link
Contributor Author

e-t-k commented May 24, 2016

Commit c629098 in reference to this issue; adds simple mailto: link. Necessary further improvements:

  • Improve appearance of sharing dialog -- make email icon inline with other icons
  • make email icon same size as other icons

Possible further improvements needing discussion as to whether and how to implement:

  • If a post includes a link, all sharing options link directly to that link instead of to the post. Would suggest linking to the post instead.
  • use Telescope.email.buildAndSend to send email directly from MedBook. This (should or should not?) include post contents and any files attached to the post
  • Collaboration awareness: warn (or forbid?) the user if the post is not otherwise publicly visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant