Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed up & refactor fitting/scoring.py #11

Open
PhilippKaniuth opened this issue Oct 15, 2021 · 0 comments
Open

speed up & refactor fitting/scoring.py #11

PhilippKaniuth opened this issue Oct 15, 2021 · 0 comments
Assignees
Labels
cleanup Deprecate unnecessary code / refactor existing code enhancement Code improvement

Comments

@PhilippKaniuth
Copy link
Member

Speed up and possibly fuse both functions.

Suggestions:

  • if score_type=='pearson':
    • use np.corrcoef to replace at least one for-loop (in case of scoring when multioutput & evaluating alphas: first change order of for-loops to then replace the then inner for-loop over targets)
  • if score_type!='pearson':
    • use some sort of mapfunc
  • use numba/etc for remaining for-loop
@PhilippKaniuth PhilippKaniuth added enhancement Code improvement cleanup Deprecate unnecessary code / refactor existing code high priority Do this first labels Oct 15, 2021
@PhilippKaniuth PhilippKaniuth added middle priority Do this second and removed high priority Do this first labels Apr 15, 2022
@PhilippKaniuth PhilippKaniuth removed the middle priority Do this second label Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Deprecate unnecessary code / refactor existing code enhancement Code improvement
Projects
None yet
Development

No branches or pull requests

2 participants