Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify various object names #34

Open
PhilippKaniuth opened this issue May 13, 2022 · 1 comment
Open

Clarify various object names #34

PhilippKaniuth opened this issue May 13, 2022 · 1 comment
Assignees
@PhilippKaniuth
Labels
enhancement Code improvement middle priority Do this second

Comments

@PhilippKaniuth
Copy link
Member

frrsa in frrsa/fitting/crossvalidation.py optionally returns the object predictions. This object has the hard-coded column names "dissim_target" and "dissim_predicted". In case of fitting representational matrices that contain similarities, these column names are confusing.

Either conditionally name the columns based on whether similarity or dissimilarity is predicted or use a generic name that'd cover both cases.
@PhilippKaniuth PhilippKaniuth added the enhancement Code improvement label May 13, 2022
@PhilippKaniuth PhilippKaniuth self-assigned this May 13, 2022
@PhilippKaniuth PhilippKaniuth added the middle priority Do this second label Mar 20, 2023
@PhilippKaniuth
Copy link
Member Author

Rename func collapse_RDM to sth. that reflects that it can be used for RSMs as well.

@PhilippKaniuth PhilippKaniuth changed the title Possibly confusing column names in returned predictions Clarify various object names May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilippKaniuth PhilippKaniuth

Labels
enhancement Code improvement middle priority Do this second
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PhilippKaniuth