Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move everything model-/source-specific to custom model file or source-specific extractor #92

Open
LukasMut opened this issue Oct 26, 2022 · 3 comments
Assignees
Labels
cleanup Deprecate or refactor code

Comments

@LukasMut
Copy link
Collaborator

Currently, we have some if-statements that address model-specific exceptions. Since these are exceptions rather than something general, we want to specify them in the custom model file or move them to source-specific extractor classes, if applicable. There's an if-statement that exclusively concerns clip models. This should go into the custom model file or the extractor classes for OpenCLIP.

@LukasMut LukasMut added the cleanup Deprecate or refactor code label Oct 26, 2022
@LukasMut
Copy link
Collaborator Author

@andropar Correct me if I am wrong, but I think you, Jonas and I fixed that issue in different PRs.

@andropar
Copy link
Collaborator

I think this is also related to the custom methods defined here: https://github.com/ViCCo-Group/thingsvision/blob/master/thingsvision/core/extraction/helpers.py#L58

@LukasMut
Copy link
Collaborator Author

@andropar Right. Then, this is still an open issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Deprecate or refactor code
Projects
None yet
Development

No branches or pull requests

3 participants