Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins search results page reset on an empty string #100

Open
ptrpla opened this issue Oct 2, 2024 · 2 comments
Open

Plugins search results page reset on an empty string #100

ptrpla opened this issue Oct 2, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers plugin Issue relating the Plugin Page

Comments

@ptrpla
Copy link

ptrpla commented Oct 2, 2024

Is your feature request related to a problem? Please describe.
After searching for a plugin in the search box the related plugin is shown correctly. But if a user deletes the search query the results page does not reset to the full list of plugins. Instead the user has to click on the search icon with an empty search query to see again the full list of plugins.

Describe the solution you'd like
Ideally the results should populate automatically as the search query is typed.

Additional context
Screenshot 2024-10-02 at 11 59 11

@ptrpla ptrpla added the enhancement New feature or request label Oct 2, 2024
@zAlweNy26 zAlweNy26 added the good first issue Good for newcomers label Oct 2, 2024
@zAlweNy26 zAlweNy26 added the plugin Issue relating the Plugin Page label Oct 14, 2024
@kodaline
Copy link
Contributor

@zAlweNy26 the search at the moment is not dynamic, what I mean is that, if you type your search you need to press enter or the search icon, in order to get the results. If we make a dynamic search when the search string is empty, it should be done also in the other case IMHO, for consistency. So, or we leave as it is, or we do it dynamic for all the cases... hope I am clear enough, let me know what you think

@ptrpla
Copy link
Author

ptrpla commented Oct 16, 2024

Agree - I would make it dynamic in all cases. Sorry if it wasn't clear in my first request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers plugin Issue relating the Plugin Page
Projects
None yet
Development

No branches or pull requests

3 participants