Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters for recalled memories #22

Open
pieroit opened this issue Jul 4, 2023 · 5 comments
Open

Filters for recalled memories #22

pieroit opened this issue Jul 4, 2023 · 5 comments
Labels
enhancement New feature or request memory Issue relating the Memory Page

Comments

@pieroit
Copy link
Member

pieroit commented Jul 4, 2023

Is your feature request related to a problem? Please describe.
Since we have timestamps for memories, it would be nice to have a couple of time filters in the memory page (from / to).

Steps:

  1. recall endpoint ignores time filters and the time filtering is done in the admin
  2. recall endpoint is able to filter by time interval directly in the backend

Filters (from/to) could be shown as dd/mm/yyyy and handled internally as unix timestamps (which is waaay better)

@pieroit pieroit added the enhancement New feature or request label Jul 4, 2023
@zAlweNy26 zAlweNy26 added the memory Issue relating the Memory Page label Jul 4, 2023
@zAlweNy26 zAlweNy26 changed the title Time filters for memory page Filters for recalled memories Jul 4, 2023
@zAlweNy26
Copy link
Member

zAlweNy26 commented Jul 4, 2023

It would be nice to also filter per source and score.

@pieroit
Copy link
Member Author

pieroit commented Jul 5, 2023

It would be nice to also fix per source and score.

The score is easily supported (there is already a threshold parameter that has only to be exposed (between -1 for very dissimilar, 0 orthogonal, 1 same memory).
Qdrant supports queries like: "I want k vectors with a score at least 0.45"

For the sources I guess you need an endpoint to list the unique sources? Or we insert that in the GET collections endpoint?

@zAlweNy26
Copy link
Member

It would be easier with a new endpoint to list the active users

@zAlweNy26
Copy link
Member

I would like to design this feature together if possible @pieroit , to better see where to put everything.

@pieroit
Copy link
Member Author

pieroit commented Jul 5, 2023

I would like to design this feature together if possible @pieroit , to better see where to put everything.

Yes gladly! So we can also better separate memory wipe from search ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request memory Issue relating the Memory Page
Projects
None yet
Development

No branches or pull requests

2 participants