-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core feature] Introduce a zero_value
field in LiteralType
to capture DataClasses default fields
#5887
Comments
I have some clarification questions:
For the dataclass or for the attribute with a default value, in this case
And how is this affected by the #5742 RFC? |
If you came across this paragraph, what would you think @EngHabu
|
Also is this a useful feature outside of dataclasses? |
I think I got my wires crossed. This code:
Produces:
The vanilla Which looks pretty similar to what I did but with different results. I also want to understand what
Exactly. But looks like this can be extracted from metadata with some work :) |
Motivation: Why do you think this is important?
a
'sLiteralType
would look something like this:This makes it difficult for clients (e.g. FlyteConsole) to display the zero value for
a
.Goal: What should the final outcome look like, ideally?
Flytekit should populate this value for DataClasses. I think for other types the zero value is just empty/null
This is not to be confused with "default value"...
Describe alternatives you've considered
Parse
metadata
and extract field information from there...Propose: Link/Inline OR Additional context
No response
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: