-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12.2 config issue #25
Comments
i tried replicating the logic
but then it started crashlooping with no logs |
also now if you dont provide fullNameOverride the chart doesn't work. for example the PVC complains it doesn't have a name |
@hooray4me can you elaborate? |
It's been a minute since I looked at this chart, but wg-access-server.fullname didn't exist... wg-access-server.name pulls from the Chart name. |
Now I remember... the helper's logic was producing a blank result for wg-access-server.fullname
^ That with the default values in the values.yaml of It made more sense to ride off the Chart name. |
Ah sorry, only just got back around to checking the latest version, Can confirm 12.3 with that config injection rollback all is working again |
Hmm actually spoke too soon, 12.3 seems to never add the config.yaml either? |
I can confirm that the issue persists, I just tested it when trying to update to the latest version. I think this could be a small PR to fix this. @phyzical feel free to create one, I'll merge it. |
It looks like I can no longer merge PR In this project, so I'm sorry for the misleading info. Still, good PR will probably be merged. I don't have time for that now, so I won't promise I will create one by myself. @phyzical I managed to use your workaround also adding MTU setting for clientConfig. Without it, it failed as you observed with yaml parser trying to convert an empty string to an integer. I think the chart default value should be set the same as it is for wireguard mtu setting
|
@elcomtik thx ill try adding the clientConfig mtu default and try updating again, if it works ill adds these as defaults in a pr |
wg-access-server-0.12.1...wg-access-server-0.12.2#diff-59df7a132e09c397ffc236cf3e4a6786ad1324a5639f8ea0b81a6911f08c6ac5R109-R111
Any one know why this line was removed?
Now it seems to just ignore the configmap entirly
The text was updated successfully, but these errors were encountered: