Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pbr-visualizer embree compiling error #3

Open
ttsesm opened this issue May 6, 2020 · 4 comments
Open

pbr-visualizer embree compiling error #3

ttsesm opened this issue May 6, 2020 · 4 comments

Comments

@ttsesm
Copy link

ttsesm commented May 6, 2020

Hi @gerardsimons I am trying to compile the pbr-visualizer and I am getting the following error:

../pbr-visualizer/common/simd/sseb.h:108:29: error: could not convert ‘_mm_shuffle_epi32(a, ((((i3 << 6) | (i2 << 4)) | (i1 << 2)) | i0))’ from ‘__m128i’ {aka ‘__vector(2) long long int’} to ‘const embree::sseb’
  108 |     return _mm_shuffle_epi32(a, _MM_SHUFFLE(i3, i2, i1, i0));
      |            ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                             |
      |                             __m128i {aka __vector(2) long long int}

Do you know how I could solve it?

I am using Embree 3.9 and GCC 9.3.0 and I am on a linux system.

Thanks.

@gerardsimons
Copy link
Owner

Hi there! So sorry about the delay. I haven't looked at this code for a while. Are you still facing this issue? I can try and run it again for you. What C++ version are you using? Though the most likely candidate seeing how old this code is is that it's not compatible with the newer version of EMBREE.

@ttsesm
Copy link
Author

ttsesm commented May 13, 2020

No worries, as I've mentioned I am using GCC 9.3.0 so it should support C++14 which is a requirement. Yes, I think the issue has to do with the new EMBREE lib version. I tried to make some changes in the common folder, but I didn't manage to make it work at the end. I am not sure how easy would be to update the code for the new EMBREE lib version.

@gerardsimons
Copy link
Owner

I think it would be easier to try older versions of EMBREE:

https://github.com/embree/embree/releases

It's a bit silly that I did not list the exact version of EMBREE we rely on. @TobiasRp Do you remember which exact one we used? Otherwise go back to around the time that this was last updated... Sorry that I cannot help more at this time. Will try to find some time in the future to try and upgrade.

@ttsesm
Copy link
Author

ttsesm commented May 15, 2020

@gerardsimons thanks for the feedback. I will try to check with an older version of EMBREE once I find some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants