-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(analytics): add new item attributes for analytics events. #8000
feat(analytics): add new item attributes for analytics events. #8000
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Eduardo Villagrán Morales seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evillagran - thank you for opening PR! Do you mind following up on all events and checking what has changed, please? 😄
@@ -120,7 +128,7 @@ export const PostScore = struct({ | |||
character: 'string?', | |||
}); | |||
|
|||
export const Refund = struct({ | |||
export const Purchase = struct.interface({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to me that purchase is missing properties: https://firebase.google.com/docs/reference/android/com/google/firebase/analytics/FirebaseAnalytics.Event?_gl=1*1qb0u75*_up*MQ..*_ga*OTc1NzI2NTU0LjE3MjUzNTM4NTA.*_ga_CW55HF8NVT*MTcyNTM1Mzg0OS4xLjAuMTcyNTM1Mzg0OS4wLjAuMA..#PURCHASE()
Might be worth going through each event and adding/removing properties for each event
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
Description
New attributes are added for analytics event items.
Related issues
NA
Release Summary
NA
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter