Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analytics): add new item attributes for analytics events. #8000

Closed

Conversation

evillagran
Copy link

Description

New attributes are added for analytics event items.

Related issues

NA

Release Summary

NA

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

analytics().logAddToWishlist({
    items: [
        {
            quantity: 1,
            price: 12345.0,
            creative_slot: 'c_slot',
            creative_name: 'c_slot_name',
            promotion_id: 'prom_id',
            promotion_name: 'prom_name',
            affiliation: 'affiliation 1',
            coupon: 'cupon_12',
            discount: '12%',
            index: 1,
            item_id: 'i_id',
            item_name: 'i_name',
            location_id: 'loc_id',
        },
    ],
    currency: 'CLP',
    value: 12345,
    
  });
imagen

Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 4:52pm

@CLAassistant
Copy link

CLAassistant commented Aug 30, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Eduardo Villagrán Morales seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evillagran - thank you for opening PR! Do you mind following up on all events and checking what has changed, please? 😄

@@ -120,7 +128,7 @@ export const PostScore = struct({
character: 'string?',
});

export const Refund = struct({
export const Purchase = struct.interface({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

github-actions bot commented Oct 1, 2024

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Oct 1, 2024
@github-actions github-actions bot removed the Stale label Oct 9, 2024
@evillagran evillagran closed this by deleting the head repository Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants