Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-Droid #25

Closed
IzzySoft opened this issue Jan 31, 2019 · 18 comments
Closed

F-Droid #25

IzzySoft opened this issue Jan 31, 2019 · 18 comments

Comments

@IzzySoft
Copy link

F-Droid maintainer here. We received a request to include your app with our catalogue. Hoping you're not opposed to that: in order to fulfill that wish, we'd need the Android project is included in the repository, otherwise we cannot build Cordova/Ionic apps. Could you help us with that? Thanks in advance!

@Sispheor
Copy link
Member

Hi, what do you mean by Android Project? The build?

@IzzySoft
Copy link
Author

I'm no dev, so I just forward this. IIRC it's some folder named project/android/ (or the other way around?).

@Sispheor
Copy link
Member

The fact is that usually you don't push built stuff in git. Maybe we can push it in a non linked branch like for the build of a GitHub page, what do you think?

@IzzySoft
Copy link
Author

IzzySoft commented Feb 1, 2019

A git submodue should do IMHO. I doubt a Github page would do. @Rudloff could say for sure.

@Sispheor
Copy link
Member

Sispheor commented Feb 1, 2019

I was not saying that a github page would do the job. I proposed to copy the model of using a dedicated branch to provide the built part. This is how Github pages work, you need to push in a branch called "gh-page" which is not related to a branch of the project.
The fact is that we don't want to add built stuff in our main branch.

@Rudloff
Copy link

Rudloff commented Feb 1, 2019

I think @Sispheor meant an alternative branch like what is used for GitHub pages, not an actual GitHub page.
We can certainly use a different branch than master, but it would help to have tags pointing to that so we know which commits to package.

@Sispheor
Copy link
Member

Sispheor commented Feb 1, 2019

@LaMonF

LaMonF added a commit that referenced this issue Feb 3, 2019
This branch is not supposed to be merged to master !
@LaMonF
Copy link
Member

LaMonF commented Feb 3, 2019

@Rudloff @IzzySoft
I just made a specific branch with the android platform (is it what you expect ?). You can find the /android repo following this link :
https://github.com/kalliope-project/kalliope-app/tree/F-Droid/kalliope/platforms/android

I also created a tag as you required : https://github.com/kalliope-project/kalliope-app/releases/tag/F-Droid-0.1

@Rudloff
Copy link

Rudloff commented Feb 3, 2019

That is exactly what we need, thanks!

@Rudloff
Copy link

Rudloff commented Feb 3, 2019

I think I spoke too soon.
The app builds correctly but crashes with this error:

02-03 17:19:43.818  8042  8077 E AndroidProtocolHandler: Unable to open asset URL: file:///android_asset/www/index.html

I think the kalliope/platforms/android/app/src/main/assets/www/ folder is missing.

LaMonF added a commit that referenced this issue Feb 3, 2019
@LaMonF
Copy link
Member

LaMonF commented Feb 3, 2019

@Rudloff Ok www/ was still in the gitignore ....
I updated the branch and the tag. It should be fine now :)

@Rudloff
Copy link

Rudloff commented Feb 3, 2019

Yes, it works correctly now. Thank you!

@Rudloff
Copy link

Rudloff commented Feb 3, 2019

I noticed two problems with the cordova-plugin-geofence plugin you are using:

  • It contains a prebuilt gson library and we require everything to be built from source. (But that it not a huge issue, it is pretty easy for us to rebuild this library.)
  • It requires Play Services and we don't allow non-free libraries.

Could your app work without this plugin?

@LaMonF
Copy link
Member

LaMonF commented Feb 3, 2019

@Rudloff Yes, this is the old but default plugin provided by ionic : https://ionicframework.com/docs/native/geofence/ . Unfortunately we are not responsible for the packaging of this library.

I am not aware of another library to provide the same features on ionic.

The app might works without this library, but it will miss some features obviously.

@Rudloff
Copy link

Rudloff commented Feb 3, 2019

Unfortunately we are not responsible for the packaging of the of this library.

I asked upstream about this, but the latest release was almost 2 years ago so I would not count on it.

The app might work without this library, but it will miss some features obviously.

Do you think it would be possible to remove this plugin from the F-Droid branch?
I would understand if it is too much work for you, but without that, I am afraid we won't be able to package your app.

@Sispheor
Copy link
Member

Sispheor commented Feb 3, 2019

Not really a good idea from my point of view to remove features just to be available on this alternative store.

@NextDev65
Copy link

NextDev65 commented Sep 13, 2021

Is it doable to remove the plugin just for the fdroid version?

@Sispheor
Copy link
Member

Like I said. We are not going to create dedicated version in order to be compliant with an alternative store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants