Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse the mechanism for ingredients extraction for packagings #1070

Closed
2 tasks
Tracked by #515
teolemon opened this issue Feb 5, 2022 · 2 comments · Fixed by #2383 or #2436
Closed
2 tasks
Tracked by #515

Reuse the mechanism for ingredients extraction for packagings #1070

teolemon opened this issue Feb 5, 2022 · 2 comments · Fixed by #2383 or #2436
Assignees
Labels
✏️ Contribution ✏️ Editing - Packaging input Related to the structured input of food packaging. ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🎯 P1 Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.
Milestone

Comments

@teolemon
Copy link
Member

teolemon commented Feb 5, 2022

What

Part of

@teolemon teolemon added Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users ✏️ Editing - Packaging input Related to the structured input of food packaging. labels Feb 5, 2022
@teolemon teolemon added this to the V2 milestone Mar 31, 2022
@teolemon
Copy link
Member Author

@monsieurtanuki on packaging, it's probably one promising road

@teolemon teolemon modified the milestones: V2, V1.1 Jun 24, 2022
@monsieurtanuki monsieurtanuki self-assigned this Jun 25, 2022
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jun 25, 2022
New files:
* `ocr_helper.dart`: OCR Helper, to be implemented for ingredients and packaging for instance.
* `ocr_ingredients_helper.dart`: OCR Helper for ingredients.
* `ocr_packaging_helper.dart`: OCR Helper for packaging.
* `tmp_ocr_packaging_result.dart`: to be moved to off-dart.

Impacted files:
* `app_en.arb`: added 6 labels for packaging OCR.
* `edit_ingredients_page.dart`: refactored around new class `OcrHelper`.
* `edit_product_page.dart`: added access to edit OCR packaging; refactored.
* `knowledge_panels_builder.dart`: refactored.
* `product_query.dart`: added packaging fields to the product fields we get from the server.
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jun 25, 2022
…revious version

Impacted files:
* `edit_ingredients_page.dart`
* `ocr_helper.dart`
monsieurtanuki added a commit that referenced this issue Jun 25, 2022
New files:
* `ocr_helper.dart`: OCR Helper, to be implemented for ingredients and packaging for instance.
* `ocr_ingredients_helper.dart`: OCR Helper for ingredients.
* `ocr_packaging_helper.dart`: OCR Helper for packaging.
* `tmp_ocr_packaging_result.dart`: to be moved to off-dart.

Impacted files:
* `app_en.arb`: added 6 labels for packaging OCR.
* `edit_ingredients_page.dart`: refactored around new class `OcrHelper`.
* `edit_product_page.dart`: added access to edit OCR packaging; refactored.
* `knowledge_panels_builder.dart`: refactored.
* `product_query.dart`: added packaging fields to the product fields we get from the server.
@monsieurtanuki
Copy link
Contributor

Needs minor refactoring with off-dart 1.20.0 new methods from openfoodfacts/openfoodfacts-dart#494.

monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jun 30, 2022
Delete file:
* `tmp_ocr_packaging_result.dart`: now it's in off-dart

Impacted file:
* `ocr_packaging_helper.dart`: now uses off-dart
monsieurtanuki added a commit that referenced this issue Jun 30, 2022
Delete file:
* `tmp_ocr_packaging_result.dart`: now it's in off-dart

Impacted file:
* `ocr_packaging_helper.dart`: now uses off-dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Contribution ✏️ Editing - Packaging input Related to the structured input of food packaging. ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🎯 P1 Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.
Projects
Status: Done
Archived in project
2 participants