Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions Find replacement for Update-Release action #359

Open
danoli3 opened this issue Mar 12, 2024 · 14 comments
Open

Actions Find replacement for Update-Release action #359

danoli3 opened this issue Mar 12, 2024 · 14 comments
Assignees
@danoli3
Labels
enhancement

Comments

@danoli3
Copy link
Member

danoli3 commented Mar 12, 2024

Need to find a replacement for

 uses: johnwbyrd/[email protected]

<!DOCTYPE html>
build-macos-platforms (3)Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: johnwbyrd/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
--
build-macos-platforms (3)The following actions uses node12 which is deprecated and will be forced to run on node16: johnwbyrd/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build-macos-platforms (3)

[build-macos-platforms (3)](https://github.com/openframeworks/apothecary/actions/runs/8232163873/job/22508987861)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: johnwbyrd/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
[build-macos-platforms (3)](https://github.com/openframeworks/apothecary/actions/runs/8232163873/job/22508987861)
The following actions uses node12 which is deprecated and will be forced to run on node16: johnwbyrd/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
[build-macos-platforms (3)](https://github.com/openframeworks/apothecary/actions/runs/8232163873/job/22508987861#step:13:17)

16 about to marked as unusable due to security issues.
OG @johnwbyrd has archived his repo, unless he wants to update it, we need to replace it with another one
@danoli3
Copy link
Member Author

danoli3 commented Mar 12, 2024

https://github.com/marketplace/actions/gh-release

@danoli3
Copy link
Member Author

danoli3 commented Mar 22, 2024

This is actually causing a bug randomly with one of the release tags conflicting, need to address this as having to manually go in and remove XROS 03 randomly for a build success on bleeding main/master

@danoli3 danoli3 self-assigned this Mar 22, 2024
@johnwbyrd
Copy link

I do not recommend that you depend on that code. I initiated it as an experiment at the time, and since then many superior options have surfaced.

@dimitre
Copy link
Member

dimitre commented May 27, 2024

softprops/action-gh-release ?

@danoli3
Copy link
Member Author

danoli3 commented Jun 26, 2024

I'm not sure if action-gh-release is working on projectGenerator it seemed to have some serious issues recently

@danoli3
Copy link
Member Author

danoli3 commented Aug 24, 2024

Thanks @johnwbyrd it has worked great for a long time regardless haha!

There is currently an issue just manfiested today deploying gzip to release with the trailing & and failing on windows releases today

@danoli3
Copy link
Member Author

danoli3 commented Oct 16, 2024

Okay this is currently the main issue the VS releases... we need to look at replacing the GH Action

@dimitre
Copy link
Member

dimitre commented Oct 16, 2024

I'm using softprops/[email protected]
here https://github.com/dimitre/ofbuild

@danoli3 danoli3 mentioned this issue Oct 28, 2024
Merged
@danoli3
Copy link
Member Author

danoli3 commented Oct 29, 2024

Nice this is looking good. I've just re-written the VS actions to support this softprops release and its working great.

Also I've added support for TAGS to auto build to those tags. Looking good!

Updating artifacts to use tags/release to fix any cache issues I could think of.

Re: Tags: This will allow for @ofTheo to just tag at any point the libraries to a version and it will auto build to releases, ez pz

@dimitre
Copy link
Member

dimitre commented Oct 29, 2024

Hey @danoli3 great news! I suggest we use tags for any apothecary changes, so for a specific OF release it can point to a specific Apothecary release.
I've been using tags for release versions here https://github.com/dimitre/ofbuild/releases

@dimitre
Copy link
Member

dimitre commented Oct 29, 2024

about versions: if apothecary is broken again for any reason we can hang on a specific version

@danoli3
Copy link
Member Author

danoli3 commented Oct 29, 2024

Yeah tags are now working it will build for that tag, I'm testing with Latest, but any tag will work, version number etc. Just fixing up some cache issues

@danoli3
Copy link
Member Author

danoli3 commented Oct 29, 2024

We can apply the same code to pG and oF releases also

@dimitre
Copy link
Member

dimitre commented Oct 29, 2024

Yes. it will be great! we can have lots of intermediate releases in OF it will be great
and PG is great. nice to debug with ever incrementing versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danoli3 danoli3

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dimitre @danoli3 @johnwbyrd