-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ambiguous error on startup #944
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore this message, accident
Would be nice if this could be merged and released soon. In my team multiple developers ran into this when trying to connect with wrong credentials and the "cannot read property "replace" of undefined" was not very helpful. |
This runtime type error causes the application to terminate if the connection to the database fails unexpectedly. As a result, the reconnection mechanism cannot take effect. |
Is there anything blocking this from being merged? Would be really good to get this into a release. The issue has been around since beginning of this year causing applications to terminate like @fin-dogedev says. Any thoughts @patrickReiis , @porsager ? |
Please merge this. |
there are no tests so that means I need to spend time to make them and verify the fix myself - I'm not on a big surplus of time at the moment, and don't use deno myself, so can't easily verify the pr myself. |
also changes should only be made to the src, the rest of the files are auto generated |
FYI it also happens in the Node.js version I am using Also it is an uncaught exception that kills the process, so not sure how to write a test for it. I guess spawn/exec and read the error output? The fix is very simple though so not sure a test is required. In addition to the code changed, also see the root of the issue noted here: |
Fixes #923
Before & after: