Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose @types/_internal #156

Open
nickmessing opened this issue Jul 6, 2024 · 2 comments
Open

Expose @types/_internal #156

nickmessing opened this issue Jul 6, 2024 · 2 comments
Assignees
Labels
more info required Could you answer a few extra questions to clarify?

Comments

@nickmessing
Copy link

Is your feature request related to a problem? Please describe.
I'm working on vue-tinybase (really early-stage for now), and I use types defined as "internal" for some type computations. Is it an option to expose internal types too?

Describe the solution you'd like
Add "_internal" as an exported path to package.json

Describe alternatives you've considered
I could import using absolute path and make esbuild "bundle" that types, feels very hacky tho.
I am copy/pasting the "internal" types into the source code to be able to migrate to v5 but that doesn't feel very good either.

Additional context

@jamesgpearce
Copy link
Contributor

I think this should be OK. Type system is pretty large and a few extra complexities on the edges won't hurt.

@jamesgpearce jamesgpearce self-assigned this Jul 6, 2024
@jamesgpearce
Copy link
Contributor

I look at this and some parts of it are pretty large to expose and document. Are there any key types you would really want to prioritize? Most easily I can just promote them up into the main packages.

@jamesgpearce jamesgpearce added the more info required Could you answer a few extra questions to clarify? label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more info required Could you answer a few extra questions to clarify?
Projects
None yet
Development

No branches or pull requests

2 participants