Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling/retrying transient network failures #64

Open
franklad opened this issue May 15, 2023 · 4 comments
Open

Handling/retrying transient network failures #64

franklad opened this issue May 15, 2023 · 4 comments

Comments

@franklad
Copy link

Hi everyone,

Sometimes when merge-gatekeeper tries to call GitHub API, GitHub returns 5xx errors or EOF and they tend to be all transient network errors.

Would you be open to adding retries to GitHub API calls? I'm happy to discuss more and add the functionality.

Initial thoughts were adding retry flag to the cli and adding a retry roundTripper to the GitHub client.

@rytswd
Copy link
Contributor

rytswd commented May 24, 2023

Hi @franklad! Sorry for getting back to you late, we are certainly open to ideas to make Merge Gatekeeper more resilient and reliable! It makes sense to handle some transient errors by retrying them, and we would definitely look more closely 👍

@franklad
Copy link
Author

Added this PR: #67. Let me know what you think, happy to make changes.

@omer2500
Copy link

omer2500 commented Jun 1, 2023

@franklad you mentioned network issues
what about jobs that didn't exist or created yet ? does the github api will return 500 for such a request?

Thanks for the pr!

@franklad
Copy link
Author

Hey @omer2500, sorry for the late response. They return 400s afaik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants