Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws-sdk to v3 in 'Use AWS:S3 As Storage' Documentation #874

Open
ThaumRystra opened this issue Jun 20, 2023 · 4 comments
Open

Update aws-sdk to v3 in 'Use AWS:S3 As Storage' Documentation #874

ThaumRystra opened this issue Jun 20, 2023 · 4 comments

Comments

@ThaumRystra
Copy link

ThaumRystra commented Jun 20, 2023

In the documentation for using AWS:S3 As Storage, aws-sdk is at version 2.240.1, which now causes the following warning:

NOTE: We are formalizing our plans to enter AWS SDK for JavaScript (v2) into maintenance mode in 2023.

Please migrate your code to use AWS SDK for JavaScript (v3).
For more information, check the migration guide at https://a.co/7PzMCcy
@dr-dimitru
Copy link
Member

@ThaumRystra would you love to send a PR?

@ThaumRystra
Copy link
Author

ThaumRystra commented Jul 1, 2023

I'm too dumb to get it to work right, so I am stuck on AWS 2.240 until I figure it out.

I'll submit a PR if I manage to get it working properly on AWS v3.

@jacoatvatfree
Copy link

Also note that trying to use AWS SDK v3 will throw a warning that Node 14 is no longer supported from 1 May 2024, so until meteor switches to a later Node version, there will be warnings.

@dr-dimitru
Copy link
Member

@jacoatvatfree true, would like to submit a PR, at least as WIP, I will help to finalize, and I'm sure community would join too. Perhaps you have a project from where you can copy-paste general changes required for v3?

If you're going to submit a PR let's postfix files with v2 and v3 so we can reference S3 integrations in the docs for all of its versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants