Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom runtime environment in Typescript actions #404

Open
IoannisF-NRB opened this issue Sep 6, 2024 · 3 comments
Open

Add custom runtime environment in Typescript actions #404

IoannisF-NRB opened this issue Sep 6, 2024 · 3 comments
Labels
area/aria area/polyglotpkg Relates to polyglotpkg module or archetype kind/feature New Feature to the project priority/low triage/accepted The issue was accepted and will be done version/minor Introduces a non-breaking feature or change

Comments

@IoannisF-NRB
Copy link

Description

I'd like to suggest some improvements to the package. Currently, there is no way to know how to change the runtime when creating a new typescript action on a maven generated project.
They are 2 things that could be good to add to the vropkg library in order to improve it:

  • A clear documentation with all the annotations that we can add on the action file that are taken into account during packaging process and the impact that it has on the Aria Orchestrator Action configuration once imported (I'm talking about this section):
    image

  • Add the possibility to add some custom runtimes that we've define if Aria Orchestrator.
    For example:

    • I configure a new environment configuration asset with some external libraries in it to execute some specific code inside a nodejs environment :
      image
    • With this new configured environment, I'd like to create an action that will use the libraries defined inside it. So I want to create an action using this environment. This is feasible if I create an action directly in Aria Orchestrator by selecting the desired environment when creating the action.
      BUT This is not possible to do so if I want to use it from a maven package and import it. I won't be able to compile my package if I change the runtime name with my newly created environment.

    So I was wondering if it is possible to add something in the package that would allow us to use a custom environment runtime inside the typescript annotations by its name only (not by its ID) ?

Alternatives

We can create all the actions in the Orchestrator and call them. But it's really heavy when we start to have multiple actions using a custom environment runtime.

Additional Context

/

@VenelinBakalov VenelinBakalov added the triage/needed Needs to be discussed by project maintainers label Sep 9, 2024
@VenelinBakalov VenelinBakalov added triage/accepted The issue was accepted and will be done priority/low area/polyglotpkg Relates to polyglotpkg module or archetype area/aria kind/feature New Feature to the project version/minor Introduces a non-breaking feature or change and removed triage/needed Needs to be discussed by project maintainers labels Oct 3, 2024
@VenelinBakalov
Copy link
Collaborator

Accepted on roadmap meeting 03/10/24
The following points need to be considered when implementing this:

  1. The first target for implementation needs to be XML archetype, adding Environments as one of the supported types for push and pull
  2. Potentially, this can be included either in TS archetype or in polyglot archetype with type vro
  3. Needs to be researched whether to overwrite an already existing Environment with the same name. Note that Environments are exportable as part of vRO package so overwrite behaviour might not be adjustable.
    image

@akantchev akantchev self-assigned this Oct 7, 2024
@pe1pip
Copy link
Contributor

pe1pip commented Oct 15, 2024

for polyglot (PowerCLI) this would help a lot for us as well.

@IoannisF-NRB
Copy link
Author

  1. Potentially, this can be included either in TS archetype or in polyglot archetype with type vro

For your second point here, in our UC, we don't need for xml, but for typescript, so it would be great to have it in TS.

  • We don't need to import an environment, we only need to import an action which depends on a pre-created environment

Thanks!

@akantchev akantchev removed their assignment Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/aria area/polyglotpkg Relates to polyglotpkg module or archetype kind/feature New Feature to the project priority/low triage/accepted The issue was accepted and will be done version/minor Introduces a non-breaking feature or change
Projects
None yet
Development

No branches or pull requests

4 participants