New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RingBuffer isn't really a ring buffer #29

Open

tom-huntington opened this issue Sep 15, 2019 · 1 comment

tom-huntington commented Sep 15, 2019

A ring buffer should write around the "edge" of the buffer. Zed's RingBuffer merely resets once it is empty.

Consider renaming to FancyBuffer or AdvancedBuffer, or change the implementation to write around the edge.

rreagan3 commented Jun 18, 2022

I should have checked here hours ago - I thought I was crazy or that there was some memcpy magic i didn't understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment