Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RingBuffer isn't really a ring buffer #29

Open
tom-huntington opened this issue Sep 15, 2019 · 1 comment
Open

RingBuffer isn't really a ring buffer #29

tom-huntington opened this issue Sep 15, 2019 · 1 comment

Comments

@tom-huntington
Copy link

A ring buffer should write around the "edge" of the buffer. Zed's RingBuffer merely resets once it is empty.

Consider renaming to FancyBuffer or AdvancedBuffer, or change the implementation to write around the edge.

@rreagan3
Copy link

I should have checked here hours ago - I thought I was crazy or that there was some memcpy magic i didn't understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants