Clean up source file headers (resolves #309, #310) #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
| @@ -1,4 +1,5 @@ | |||
| # Copyright (C) 2015 UCSC Computational Genomics Lab | |||
| # | |||
| # Copyright 2015–2016, Regents of the University of California | |||
There was a problem hiding this comment.
Should we do this in Toil, too?
There was a problem hiding this comment.
I generally prefer the Regents of the University of California copyright—esp. if you have contributors from multiple UCs—but I'm not picky.
|
Build fails with |
Hah! I got cocky and used an en dash instead of a hyphen in 2015–2016. Will fix. |
Adds the following text: ``` # # Copyright 2015–2016, Regents of the University of California # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. # ``` As a header to all source files, as suggested as a best practice by [the Apache Software Foundation](http://www.apache.org/licenses/LICENSE-2.0.html#apply).
fnothaft
force-pushed
the
issues/309-310-clean-up-headers
branch
from
661d518
to
3c93ee7
Compare
|
Rebased and addressed buld issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes two changes:
NOTICES.txtfile if making the copyright more specific.@authortags, as per discussion with @benedictpaten @hannes-ucsc on today's scrum.