-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to getLiteUser where applicable on frontend #4951
base: develop
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wow such a nice job, looking good! |
I'll test to see if everything works good on the page |
@aapeliv @bakeiro just checking up on this one. I did click around the app already for this but if anyone wants to take a second look I couldn't check the reference user info as I don't have any references in my test account (and can't add as I'm blocked by not having a profile photo and doesn't let me upload one on localdev). Although we had pretty good tests for most of these components so hopefully it would catch anything. |
sorry, totally forget, if the test was good then is a ready to go for me, I´ll check it briefly, if all good I approve it :) |
This is exciting to see - the original |
Thanks for this, I was getting hung up on refactoring the existing hook but this made me realize I should just re-write and use my own common sense haha, since the whole api call works differently. Done now, re-wrote the tests. Could be missing some test cases, but I have most of the old ones covered (except the invalidate param since we don't need to pass that anymore). |
This PR switches out
useUser
anduseUsers
withuseLiteUser
anduseLiteUsers
, which returns a much smaller user object. Backend code was already merged for this.HOW TO TEST
Closes #4936
Web frontend checklist
yarn format
yarn lint --fix