Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add terra-rstudio-pro-base #111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Add terra-rstudio-pro-base #111

wants to merge 1 commit into from

Conversation

rtitle
Copy link
Collaborator

@rtitle rtitle commented Apr 16, 2020

Creating this PR as I'm testing RStudio Pro licensing through Leo. It seems to work with this image.

TODO:

  1. Update documentation and CI
  2. Determine if anything else should be added to the base image (more Bioc setup?)
  3. Review with security team -- is using rstudio/rstudio-server-pro:1.2.5042-1 as a base image OK?

@rtitle
Copy link
Collaborator Author

rtitle commented Apr 28, 2020

@nturaga you might have seen this PR. Just to give some context: I opened it as a POC to prove that RStudio Pro licensing works through Leo (it does). It's not ready to merge.

I think we should do the same Bioc setup that you've done for the other R images. Your input would be welcome here.

The other major thing to do is work with @adrazhi from a security perspective -- e.g. not sure if we should use a different base image.

This work is tracked in https://broadworkbench.atlassian.net/browse/IA-1815 btw

@nturaga
Copy link
Collaborator

nturaga commented Apr 29, 2020

Hi @rtitle

I've seen the PR. It's great that we have a working version of this. I will work on a PR of "this" branch to build an RStudio pro bioconductor image.

I'll get back to you shortly.

Thanks!

@rtitle
Copy link
Collaborator Author

rtitle commented Apr 29, 2020

Thanks, that'd be great!

I think this image is intended to eventually replace the https://github.com/anvilproject/anvil-docker repo btw -- since we have licensing in place we can put all RStudio images in the terra-docker repo.

@adrazhi
Copy link

adrazhi commented May 1, 2020

https://broadworkbench.atlassian.net/browse/IA-1815

@rtitle I run an analysis (see it here), and the rstudio/rstudio-server-pro:1.2.5042-1 does have some vulnerabilities, although not particularly scary considering what's out there in the docker world.

I was wondering if starting off with something like this would be possible.

@rtitle
Copy link
Collaborator Author

rtitle commented May 1, 2020

I was wondering if starting off with something like this would be possible.

Cool yeah I bet distroless images is possible here -- can look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants