-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autoprefix command #647
base: fabric
Are you sure you want to change the base?
Conversation
src/main/java/net/earthcomputer/clientcommands/ClientCommands.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/command/AutoPrefixCommand.java
Outdated
Show resolved
Hide resolved
import static net.fabricmc.fabric.api.client.command.v2.ClientCommandManager.literal; | ||
|
||
public class AutoPrefixCommand { | ||
private static String currentPrefix = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this entire command can be a config instead, but I will continue reviewing the command anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be a config? Should this be persistent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
configs can be temporary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Temporary configs exist. Although you would lose the autocompletion for players, unless you resort to a hack. I'll let @Earthcomputer decide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, i understand, you meant making this a config setting qwq cries
src/main/java/net/earthcomputer/clientcommands/command/AutoPrefixCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/command/AutoPrefixCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/ClientCommands.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/command/AutoPrefixCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/command/AutoPrefixCommand.java
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/command/AutoPrefixCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/command/AutoPrefixCommand.java
Show resolved
Hide resolved
src/main/java/net/earthcomputer/clientcommands/command/AutoPrefixCommand.java
Show resolved
Hide resolved
Merge when? 🥺 |
Well there is an open question, so not yet. |
This command lets you autoprefix in all your messages a text, it can be a command or a simple text.
It's intended use is for
/msg <user>
or/tmsg
but it's a flexible addition to the mod :3