-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle package name for fonts #567
feat: handle package name for fonts #567
Conversation
The changes look good at this point, but we need tests for it. |
I've added a test case to |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #567 +/- ##
==========================================
+ Coverage 97.55% 97.62% +0.07%
==========================================
Files 24 24
Lines 860 886 +26
==========================================
+ Hits 839 865 +26
Misses 21 21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new feature!
## 5.8.0 **Feature** - [#555](#555) Support build.yaml to configure. by [@b2nkuu](https://github.com/b2nkuu) - [#567](#567) Generate the `package` constant for generated font classes. by [@TesteurManiak](https://github.com/TesteurManiak) - [#569](#569) Enables `gaplessPlayback` by default for image assets. by [@AlexV525](https://github.com/AlexV525) - [#580](#580) Allows `mime: '>=1.0.0 <3.0.0'`. by [@AlexV525](https://github.com/AlexV525) **Development** - [#563](#563) Fix concurrency execution with melos. by [@wasabeef](https://github.com/wasabeef)
What does this change?
Fixes #357 🎯
Parse
package_parameter_enabled
for the fonts property and add apackage
accessor to the generated font class.Example
Type of change
Please delete options that are not relevant.
Checklist:
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
melos run test
)melos run format
to automatically apply formatting)