Modified the script to be compatible with new K8S version #1050
Conversation
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
| @@ -30,6 +39,7 @@ while ! kubectl describe "pod/${POD_NAME}" | grep -q Terminated; do | |||
| LOGS_SINCE_TIME=$(date --iso-8601=seconds) | |||
| done | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
this new newline is probably not necessary
| --env="COMMIT_SHA=${COMMIT_SHA}" \ | ||
| --env="IMAGE_VERSION=${DATAPROC_IMAGE_VERSION}" \ | ||
| --command -- bash /init-actions/cloudbuild/presubmit.sh | ||
| #kubectl run "${POD_NAME}" \ |
There was a problem hiding this comment.
We should keep this old command in the previous commit in the main branch. Thank you for preserving the previous implementation in comments. I loathe the concept of removing the old implementation as well. We could leave this comment in for the next release for posterity and then remove them to reduce file size and execution time.
| - 'COMMIT_SHA=$COMMIT_SHA' | ||
| - 'CLOUDSDK_COMPUTE_REGION=us-central1' | ||
| - 'CLOUDSDK_CONTAINER_CLUSTER=init-actions-presubmit' | ||
| # # Run presubmit tests in parallel for 2.0 Rocky Linux image |
There was a problem hiding this comment.
again, leave the comments for posterity for one release and then remove them to reduce file size and execution time
| - 'CLOUDSDK_COMPUTE_REGION=us-central1' | ||
| - 'CLOUDSDK_CONTAINER_CLUSTER=init-actions-presubmit' | ||
|
|
||
| # # Run presubmit tests in parallel for 1.5 Debian image |
There was a problem hiding this comment.
same as the previous/next two comments. leave comments for one PR and remove them in the next to reduce file size and execution time.
| @@ -11,6 +11,6 @@ COPY --chown=ia-tests:ia-tests . /init-actions | |||
| # https://docs.bazel.build/versions/master/install-ubuntu.html | |||
| RUN echo "deb [arch=amd64] http://storage.googleapis.com/bazel-apt stable jdk1.8" | tee /etc/apt/sources.list.d/bazel.list | |||
| RUN curl https://bazel.build/bazel-release.pub.gpg | apt-key add - | |||
| RUN apt-get update && apt-get install -y openjdk-8-jdk python3-setuptools bazel | |||
| RUN apt-get update && apt-get install -y openjdk-8-jdk python3-setuptools bazel gettext-base | |||
There was a problem hiding this comment.
that seems fine. I don't see it being used below, but perhaps the kubectl apply depends on this for translation. Can you share why we included this package?
No description provided.