Add config files for Recore A6, A7 and A8 #6567
Conversation
The ina381 is a current monitor circuit with over current alarm. In order for Recore boards to work, this circuit needs a reset and that is what this plugin does. Signed-off by: Elias Bakken <[email protected]>
klippy/extras/ina381.py
Outdated
| ppins.register_chip('ina381', self) | ||
|
|
||
| # Reset over current alarm | ||
| reset_pin = config.get('reset_pin', 'ar100:PF4') |
There was a problem hiding this comment.
It would not make sense to use a default that contains a user specified mcu name.
klippy/extras/ina381.py
Outdated
| reset_pin = config.get('reset_pin', 'ar100:PF4') | ||
| oc_reset = ppins.setup_pin('digital_out', reset_pin) | ||
| mcu = oc_reset.get_mcu() | ||
| pin = oc_reset._pin |
There was a problem hiding this comment.
Code should not "peek" into class member variables of classes defined in other python files - this is mentioned briefly at https://www.klipper3d.org/Code_Overview.html#adding-a-host-module .
…ins suggestions. This is now a config PR only.
eliasbakken
changed the title
|
I've implemented this PR as a pure config file change as pr your suggestion. |
KevinOConnor
removed
the
pending feedback
|
Thanks. In general, it seems fine to me. At a minimum the configs need to be added to the build test cases though ( https://www.klipper3d.org/Example_Configs.html point 4). @JamesH1978 - do you have any comments? -Kevin |
|
Config looks fine, my only main comment would be why you have such a low min_extrude_temp and a min_temp of 1 kelvin for your extruders? Once the regression tests are added as per Kevin's comment, i will do a few review. Thanks |
|
Thank you both. I've added the config files as tests, but in order to make them pass I had to make some code changes, so I'll try and submit that as a separate PR that can be reviewed first. |
The ina381 is a current monitor circuit with over current alarm. In order for Recore boards to work, this circuit needs a reset and that is what this plugin does.
Signed-off by: Elias Bakken [email protected]