Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] account_statement_import_camt: Migration to 17.0 #684

Open
wants to merge 24 commits into
base: 17.0
Choose a base branch
from

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented Apr 22, 2024

Depends:

/ocabot migration account_statement_import_camt

@hbrunn
Copy link
Member Author

hbrunn commented Apr 22, 2024

/ocabot migration account_statement_import_camt

Copy link
Contributor

@luc-demeyer luc-demeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review & testing ok

@yankinmax
Copy link
Contributor

hello @hbrunn, can you please rebase?
account_statement_import_file is merged here:

@hbrunn hbrunn force-pushed the 17.0-mig-account_statement_import_camt branch 2 times, most recently from d580d7f to dba493b Compare May 23, 2024 13:07
@hbrunn
Copy link
Member Author

hbrunn commented May 23, 2024

@yankinmax thanks for the heads-up, done

@hbrunn hbrunn closed this Jul 31, 2024
@hbrunn hbrunn reopened this Jul 31, 2024
@OCA-git-bot
Copy link
Contributor

Hi @alexis-via,
some modules you are maintaining are being modified, check this out!

i-vyshnevska and others added 15 commits July 31, 2024 04:23
Currently translated at 75.0% (9 of 12 strings)

Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_camt
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_camt/nl/
Currently translated at 83.3% (10 of 12 strings)

Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_camt
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_camt/it/
Encountered in a Camt.054 statement: currency listed under
/BkToCstmrDbtCdtNtfctn/Ntfctn/Ntry/Amt/@ccy
with this commit, the narration field is filled with infos find in the camt file such as reversal indicator, return reason, cheque number, ...
before only a banking ref was present.

The transaction type field is also filled.
Ivorra78 and others added 9 commits July 31, 2024 04:23
Currently translated at 100.0% (12 of 12 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_camt
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_camt/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_camt
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_camt/
Currently translated at 100.0% (31 of 31 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_camt
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_camt/es/
Currently translated at 22.5% (7 of 31 strings)

Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_camt
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_camt/it/
This refactoring will allow using `TestParser._do_parse_test()` method for subclasses defined in inheriting modules.

This way, if the new module defines new files in other paths than `account_statement_import_camt/test_files/`,
 subclasses of `TestParser` will still be able to use the `_do_parse_test()` method for imports and checks.

Moreover, a custom value can now be defined for the acceptable differing lines number between inputfile and goldenfile.

It will also maintain backward compatibility with the current usage of the method
 (ie: using only a filename with the assumption of finding it in `account_statement_import_camt/test_files/`).

NB: methods are now defined outside of `TestParser` to allow importing them directly, instead of inheriting from `TestParser`.
@hbrunn hbrunn force-pushed the 17.0-mig-account_statement_import_camt branch from dba493b to b4c2426 Compare July 31, 2024 02:23
@AquaMCU
Copy link

AquaMCU commented Oct 16, 2024

Hi. Do you know when this PR will be integrated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.