-
-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] account_statement_import_base: sanitized acc number #729
base: 16.0
Are you sure you want to change the base?
[16.0][FIX] account_statement_import_base: sanitized acc number #729
Conversation
Hi @alexis-via, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK about the content. Please avoid the abbreviation in the module name for the commit message.
The field acc_number in the database is not sanitized by default. This leads to account_bank_statement_line with an empty partner_id because the check done in _statement_line_import_update_hook() uses the sanitized_acc_number instead of the acc_number. For a right comparison the sanitized version of the acc_number should be put in the speeddict.
af52cb0
to
d4dfcd5
Compare
Thanks @pedrobaeza Commit has been fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review OK
The field acc_number in the database is not sanitized by default.
This leads to account_bank_statement_line with an empty partner_id because the check done in _statement_line_import_update_hook() uses the sanitized_acc_number instead of the acc_number.
For a right comparison the sanitized version of the acc_number should be put in the speeddict.