[16.0][FIX] account_statement_import_base: sanitized acc number #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @alexis-via, |
remytms
changed the title
pedrobaeza
reviewed
Oct 19, 2024
The field acc_number in the database is not sanitized by default. This leads to account_bank_statement_line with an empty partner_id because the check done in _statement_line_import_update_hook() uses the sanitized_acc_number instead of the acc_number. For a right comparison the sanitized version of the acc_number should be put in the speeddict.
remytms
force-pushed
the
16.0-fix-account_statement_import_base-sanitized_acc_number
branch
from
af52cb0
to
d4dfcd5
Compare
remytms
changed the title
|
Thanks @pedrobaeza Commit has been fixed. |
pedrobaeza
approved these changes
Oct 20, 2024
victor-champonnois
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field acc_number in the database is not sanitized by default.
This leads to account_bank_statement_line with an empty partner_id because the check done in _statement_line_import_update_hook() uses the sanitized_acc_number instead of the acc_number.
For a right comparison the sanitized version of the acc_number should be put in the speeddict.