Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16][FIX] account_statement_import_online_paypal : search transaction with a 1 second margin to ensure it is found #730

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

florian-dacosta
Copy link
Contributor

Workaround for #726 as proposed by @Roodin
I propose it here so it is usable for people having this issue, but it may not be the best way.
I do not really know the module so I do not try something else but I do not understand why this is important : https://github.com/OCA/bank-statement-import/blob/16.0/account_statement_import_online_paypal/models/online_bank_statement_provider_paypal.py#L235

Don't we have already the transaction in first_transaction variable?, why do we need to fetch it once again ?
Maybe @alexey-pelykh could enlighten me ?

@OCA-git-bot
Copy link
Contributor

Hi @alexey-pelykh,
some modules you are maintaining are being modified, check this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants