Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some formatting and grammar improvements. #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Some formatting and grammar improvements. #37

wants to merge 1 commit into from

Conversation

adymitruk
Copy link

No description provided.

tfuxu
tfuxu approved these changes Oct 27, 2022
View reviewed changes
Copy link

@tfuxu tfuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are mostly correct, some of them are already in port-gtk4 branch, but it shouldn't be a problem to merge this PR if changes from that branch will be incorporated.

src/components/SelectPictureDialog.vala
@@ -1,7 +1,7 @@
class SelectPictureDialog : Hdy.Window {
public SelectPictureDialog (Gtk.Label title_label) {
var dialog_handle = new Hdy.WindowHandle () ;
var pic_dialog_title = new Gtk.Label ("Where can I find the Image ?") ;
var pic_dialog_title = new Gtk.Label ("Where can I find the image ?") ;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also remove a space between word image and a question mark

src/services/TesseractTrigger.vala
@@ -17,7 +17,7 @@ class TesseractTrigger : Object {
public void accept_files_fromchooser () {
portal.open_file.begin (
null,
"Select an Image to perform OCR !",
"Select an image to perform OCR !",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as in the comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfuxu tfuxu tfuxu approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adymitruk @tfuxu