Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/load profiles from url #697

Draft
wants to merge 68 commits into
base: develop
Choose a base branch
from

Conversation

jwaspin
Copy link
Contributor

@jwaspin jwaspin commented Oct 4, 2024

Guidelines

Create issue first

#584

Test plan

http://23.23.4.125:8003/

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

Pull Request

  • Please check if the PR fulfills these requirements

    • The commit message follows our guidelines
    • Tests for the changes have been added (for bug fixes / features)
    • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

New feature to load profiles from URL.

REMOVED: NGGDPP profiles are no longer default profiles and will not be loaded automatically, they need to be loaded via the URL

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

This change is temporary and needs to be overwritten
once mdProfiles changes are available in the master branch.
NGGDPP profiles have been isolated from the core profiles in
mdProfiles (not yet in master branch).
Using the query parameter "loadProfilesFrom" with a URL to
the profiles list file, this change will load those profiles in the
same way as the core profiles are loaded.
Loading the custom profile into the store needed
to be wrapped in a config object.
Change URLs to base URLs.
Add manifestPath variable.
Update loadVocabularies to use async/await.
Not done yet, but major improvements here.
Profiles is now just loading core profiles.
Custom-profiles is loading profiles from the query paramter.
Convert Ember functions to native JavaScript
and change yield to async/await.
Saving progress in loadCustomProfilesFromUrl.
When adding custom profiles from a url query parameter,
the store is checked for existing records before adding new profiles.
jwaspin and others added 23 commits October 27, 2023 13:21
Code formatting.
Fix bug related to profiles without thesauri object.
Reverting back did not solve the problem of importing profiles from a uri. That issue is much older.
…of github.com:adiwg/mdEditor into 584-dynamic-load-custom-profiles-from-query-param-url
…ng imported is fixed. New logic supports those types being loaded and imported correctly. (#691)
@jwaspin jwaspin marked this pull request as draft October 4, 2024 17:50
@jwaspin jwaspin linked an issue Oct 7, 2024 that may be closed by this pull request
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load Custom Profiles from URL
1 participant