Feature/load profiles from url #697
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is temporary and needs to be overwritten once mdProfiles changes are available in the master branch.
NGGDPP profiles have been isolated from the core profiles in mdProfiles (not yet in master branch). Using the query parameter "loadProfilesFrom" with a URL to the profiles list file, this change will load those profiles in the same way as the core profiles are loaded.
Loading the custom profile into the store needed to be wrapped in a config object.
Change URLs to base URLs. Add manifestPath variable. Update loadVocabularies to use async/await.
Not done yet, but major improvements here. Profiles is now just loading core profiles. Custom-profiles is loading profiles from the query paramter.
When adding custom profiles from a url query parameter, the store is checked for existing records before adding new profiles.
Reverting back did not solve the problem of importing profiles from a uri. That issue is much older.
…of github.com:adiwg/mdEditor into 584-dynamic-load-custom-profiles-from-query-param-url
…ng imported is fixed. New logic supports those types being loaded and imported correctly. (#691)
…rofile controller and template
… service and remove commented code
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines
Create issue first
#584
Test plan
http://23.23.4.125:8003/
Closing issues
Put
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).Pull Request
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
New feature to load profiles from URL.
REMOVED: NGGDPP profiles are no longer default profiles and will not be loaded automatically, they need to be loaded via the URL
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: