-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update modules with missing steps #33
base: master
Are you sure you want to change the base?
Changes from all commits
9fb4ff5
0a12382
53fa194
c3d2aca
78558f8
87e1558
0c44a75
ec65cbe
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ | |
import ask_sdk_core.utils as ask_utils | ||
import os | ||
from ask_sdk_s3.adapter import S3Adapter | ||
s3_adapter = S3Adapter(bucket_name=os.environ["S3_PERSISTENCE_BUCKET"]) | ||
s3_adapter = S3Adapter(bucket_name="NAME_OF_YOUR_BUCKET_HERE") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why are we removing os.environ from here? That's how an Alexa Hosted skill references an S3 bucket created by Alexa Hosted. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please see the comment above |
||
|
||
from ask_sdk_core.skill_builder import CustomSkillBuilder | ||
from ask_sdk_core.dispatch_components import AbstractRequestHandler | ||
|
@@ -210,4 +210,4 @@ def handle(self, handler_input, exception): | |
|
||
sb.add_exception_handler(CatchAllExceptionHandler()) | ||
|
||
lambda_handler = sb.lambda_handler() | ||
lambda_handler = sb.lambda_handler() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we removing
os.environ
from here? That's how an Alexa Hosted skill references an S3 bucket created by Alexa Hosted.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using os.environ["my_bucket_name"] throws errors during testing. The log is not very descriptive but this is what it looks like.