update: add service for v2 protocol (ConfigServer) #1793
+8,762
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Takuka0311
requested changes
Oct 16, 2024
config_server/service/README.md
Outdated
| @@ -0,0 +1,69 @@ | |||
| # Config-server | |||
|
|
|||
| 本项目针对https://github.com/alibaba/ilogtail/tree/main/config_server/protocol/v2 中提到的Agent行为进行了V2版本的适配，基本实现了能力报告、心跳压缩、配置状态上报等功能；并适配用户端实现了Config-server的前端页面Config-server-ui，项目见[ui](../ui/README.md)。 | |||
There was a problem hiding this comment.
文档移到docs目录里，注意把对应的链接修改一下。另外markdown格式化一下
config_server/service/README.md
Outdated
| 下载ilogtail源码，进入`config_server/service`目录 | ||
| #### 数据库配置 | ||
|
|
||
| 由于要求ConfigServer存储Agent的基本信息、PipelineConfig、InstanceConfig等配置信息，所以首先需要对数据库进行配置。打开`cmd/config/prod`文件夹，编辑`databaseConfig.json`（若不存在，请先创建），填入以下信息，其中`type`为数据库的基本类型 （基于gorm我们适配了`mysql`、`sqlite`、`postgres`、`sqlserver`四种数据库）；其余均为数据库配置信息；`autoMigrate`字段默认为`true`，若先前建好业务相关的表，则设置为`false`。配置完成后，请自行创建可与ConfigServer连通的数据库实例，并创建名字为`dbName`的数据库(若按照docker compose方式启动，无需任何操作，参考[deployment](../deployment/README.md))。 |
config_server/service/Dockerfile-dev
Outdated
| FROM sls-opensource-registry.cn-shanghai.cr.aliyuncs.com/ilogtail-community-edition/ilogtail-build-linux:2.0.3 as build | ||
|
|
||
| USER root | ||
| WORKDIR /backend |
|
yysy，这个go代码一股子java味。。。 |
Takuka0311
requested changes
Oct 24, 2024
| func TestProto(t *testing.T) { | ||
| //NewObj[protov2.CreateAgentGroupRequest]() | ||
| NewObj[*protov2.CreateAgentGroupRequest]() | ||
| } |
There was a problem hiding this comment.
你把test都删了，结果只剩这么点test。。。原本的test里带有一些业务逻辑的，尤其是interface_test.go，看看有没有时间把测试补回来
| "path/filepath" | ||
| ) | ||
|
|
||
| type ServerConfig struct { |
There was a problem hiding this comment.
最基础的兼容还是要做的，因为也要适配v1的协议
config_server/service/config/gorm.go
Outdated
| "path/filepath" | ||
| ) | ||
|
|
||
| type GormConfig struct { |
There was a problem hiding this comment.
老的leveldb的版本需要适配，不然没办法平滑升级
| "time" | ||
| ) | ||
|
|
||
| func JudgeSequenceNumRationality(instanceId []byte, sequenceNum uint64) bool { |
There was a problem hiding this comment.
在PR里标注一下，主要的协议相关的重点逻辑在哪些目录/文件吧，review起来方便一点
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.