Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-3143] Supports executing the spotless apply command on a single module #3198

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

engraving-knife
Copy link
Contributor

Why are the changes needed?

Close #3143.

Brief change log

  • Modify the configuration file address of the spotless plug-in

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@github-actions github-actions bot added module:mixed-flink Flink moduel for Mixed Format module:mixed-spark Spark module for Mixed Format module:mixed-hive Hive moduel for Mixed Format module:mixed-trino trino module for Mixed Format type:build labels Sep 13, 2024
@zhongqishang
Copy link
Contributor

@engraving-knife Thanks for your contribution.

IMO, maybe use maven.multiModuleProjectDirectory will be better, like

<file>${maven.multiModuleProjectDirectory}/tools/maven/scalafmt.conf</file>

FYI, In Maven 4.0, more options are provided. https://issues.apache.org/jira/browse/MNG-7038

@zhongqishang zhongqishang changed the title Supports executing the spotless apply command on a single module [AMORO-3143] Supports executing the spotless apply command on a single module Sep 14, 2024
@engraving-knife
Copy link
Contributor Author

@zhongqishang Thanks for your suggestion. I tried the multiModuleProjectDirectory attribute but it doesn't seem to work.

In addition, the official provides new properties to get the root directory of multi-module projects, but I think we should not use the properties of unreleased maven versions.

image

@zhongqishang
Copy link
Contributor

zhongqishang commented Sep 15, 2024

@zhongqishang Thanks for your suggestion. I tried the multiModuleProjectDirectory attribute but it doesn't seem to work.

Sorry for the missing information, also need to configure the maven.multiModuleProjectDirectory in VM options.

image

Reference in kyuubi : https://github.com/apache/kyuubi/blob/master/pom.xml#L1670

Copy link
Contributor

@czy006 czy006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have appropriate doc describing the best practices. by the way, can this feature generate a binary installation package for a specific table's schema variation?

Copy link

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:mixed-flink Flink moduel for Mixed Format module:mixed-hive Hive moduel for Mixed Format module:mixed-spark Spark module for Mixed Format module:mixed-trino trino module for Mixed Format stale type:build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Executing spotless apply of a module alone will report an error that the file cannot be found.
3 participants