Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMORO-3303] Optimize the final tarball to keep it within the specified size for 0.7 #3304

Merged
merged 3 commits into from
Oct 30, 2024
Merged

[AMORO-3303] Optimize the final tarball to keep it within the specified size for 0.7 #3304

merged 3 commits into from
Oct 30, 2024
+40 −14

Conversation

klion26
Copy link
Member

@klion26 klion26 commented Oct 28, 2024

Why are the changes needed?

Close #3303 .

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@github-actions github-actions bot added module:mixed-flink Flink moduel for Mixed Format module:core Core module module:ams-server Ams server module module:mixed-hive Hive moduel for Mixed Format type:build labels Oct 28, 2024
zhoujinsong
zhoujinsong reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, I left some comments, PTAL.

pom.xml Outdated Show resolved Hide resolved
amoro-ams/amoro-ams-server/pom.xml Show resolved Hide resolved
amoro-ams/dist/pom.xml Outdated Show resolved Hide resolved
amoro-core/pom.xml Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the module:core Core module label Oct 29, 2024
@klion26 klion26 force-pushed the 0.7.x-shrink-jar-package branch 3 times, most recently from ad94469 to 3405104 Compare October 29, 2024 09:41
@github-actions github-actions bot added the module:core Core module label Oct 29, 2024
zhoujinsong
zhoujinsong approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for the contribution!

@zhoujinsong zhoujinsong merged commit 65127ea into apache:0.7.x Oct 30, 2024
4 checks passed
@klion26
Copy link
Member Author

klion26 commented Oct 30, 2024

@zhoujinsong thanks for the review and merging!

@klion26 klion26 deleted the 0.7.x-shrink-jar-package branch October 30, 2024 02:43
@klion26 klion26 mentioned this pull request Oct 30, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhoujinsong zhoujinsong zhoujinsong approved these changes

Assignees
No one assigned
Labels
module:ams-server Ams server module module:core Core module module:mixed-flink Flink moduel for Mixed Format module:mixed-hive Hive moduel for Mixed Format type:build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klion26 @zhoujinsong