-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMORO-3303] Optimize the final tarball to keep it within the specified size for 0.7 #3304
Merged
+40
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
module:mixed-flink
Flink moduel for Mixed Format
module:core
Core module
module:ams-server
Ams server module
module:mixed-hive
Hive moduel for Mixed Format
type:build
labels
Oct 28, 2024
zhoujinsong
reviewed
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, I left some comments, PTAL.
klion26
force-pushed
the
0.7.x-shrink-jar-package
branch
3 times, most recently
from
October 29, 2024 09:41
ad94469
to
3405104
Compare
…specified size for 0.7
klion26
force-pushed
the
0.7.x-shrink-jar-package
branch
from
October 29, 2024 11:19
3405104
to
80e2dbf
Compare
…specified size for 0.7
klion26
commented
Oct 30, 2024
zhoujinsong
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for the contribution!
@zhoujinsong thanks for the review and merging! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
module:ams-server
Ams server module
module:core
Core module
module:mixed-flink
Flink moduel for Mixed Format
module:mixed-hive
Hive moduel for Mixed Format
type:build
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #3303 .
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation