-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve list query #140
base: master
Are you sure you want to change the base?
Improve list query #140
Conversation
This PR also depends on #141 |
1866a93
to
a0f5644
Compare
Benchmark Result
Current status
|
8163d25
to
a683b84
Compare
a683b84
to
3e84f8c
Compare
0b7129e
to
e6bc004
Compare
During the development of #170 we found out that List queries cannot return PrevKV. Moreover, Update does not use Delete query is on its way to be updated as well. This means that all GET path do not really need the prevKV and we could improve the read path way more by not reading the previous value (less data to read, less allocations). There is still a place where this might happen: the watch query. Watchers might ask for prevKV. In this case we need to understand how to deal with that request (if necessary). |
e6bc004
to
f6ee479
Compare
They are literally the same query.
This is used to help move bits from logstructured to sqllog in an incremental fashion
I did not change the query yet, but it should be done as now the list query does not need to return the prev value
After all, the data structure was never a Log Structured.
…tter-get-queries-after-merge
f6ee479
to
15fae44
Compare
Depends on #195 as it removes PrevKV from the query. |
This PR changes slightly the index to make it covering when querying for latest rows.
It also changes the List query (and all those related to the same index) so that it is possible to exploit better the properties of this updated index. While doing that, it removes a redundant query.