Improve list query #140
Draft
Improve list query #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also depends on #141 |
marco6
force-pushed
the
marco6/improve-list-sql
branch
from
1866a93
to
a0f5644
Compare
Benchmark ResultCurrent status |
Merged
marco6
force-pushed
the
marco6/improve-list-sql
branch
2 times, most recently
from
8163d25
to
a683b84
Compare
marco6
force-pushed
the
marco6/improve-list-sql
branch
from
a683b84
to
3e84f8c
Compare
marco6
force-pushed
the
marco6/improve-list-sql
branch
2 times, most recently
from
0b7129e
to
e6bc004
Compare
|
During the development of #170 we found out that List queries cannot return PrevKV. Moreover, Update does not use Delete query is on its way to be updated as well. This means that all GET path do not really need the prevKV and we could improve the read path way more by not reading the previous value (less data to read, less allocations). There is still a place where this might happen: the watch query. Watchers might ask for prevKV. In this case we need to understand how to deal with that request (if necessary). |
marco6
force-pushed
the
marco6/improve-list-sql
branch
from
e6bc004
to
f6ee479
Compare
They are literally the same query.
This is used to help move bits from logstructured to sqllog in an incremental fashion
I did not change the query yet, but it should be done as now the list query does not need to return the prev value
After all, the data structure was never a Log Structured.
…tter-get-queries-after-merge
marco6
force-pushed
the
marco6/improve-list-sql
branch
from
f6ee479
to
15fae44
Compare
|
Depends on #195 as it removes PrevKV from the query. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes slightly the index to make it covering when querying for latest rows.
It also changes the List query (and all those related to the same index) so that it is possible to exploit better the properties of this updated index. While doing that, it removes a redundant query.