Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vmware vars for el9 derivitives #1519

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Conversation

drawks
Copy link
Contributor

@drawks drawks commented Jul 28, 2023

  • updates vmware_guest_os_type for almalinux and rockylinux 9 aarch64 to match the vmware hardware profile which reliably results in a successful build

Description

Neither rockylinux nor almalinux 9.x targets for aarch64 would build on vmware fusion 13.x with the current specified vmware_guest_os_type as centos is no longer an officially supported target os of VMWare it seems reasonable to adopt their RedHat targeted support when building EL derivative distros.

This change has been tested on Apple Arm64 hardware running VMWare fusion 13.0.2, similar changes might be desirable for the x86_64 targets as well, but I suspect that those guest hardware profiles are more generic and have fewer unanticipated compatibility issues.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

* updates `vmware_guest_os_type` for almalinux and rockylinux 9 aarch64
  to match the vmware hardware profile which reliably results in a
  successful build

Signed-off-by: Dave Rawks <[email protected]>
@drawks drawks requested review from a team and Stromweld as code owners July 28, 2023 16:37
@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@Stromweld Stromweld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stromweld Stromweld merged commit d56f219 into chef:main Aug 1, 2023
33 of 239 checks passed
hunleyd added a commit to hunleyd/bento that referenced this pull request Sep 9, 2023
* 'main' of github.com:chef/bento:
  Keep linux-kernel-header package installed for Parallels builds (chef#1526)
  Update Ubuntu 22.04 `iso_url` (chef#1527)
  Do not defrag and zerofill the disk twice during Windows cleanup and optimize (chef#1525)
  Update vmware vars for el9 derivitives (chef#1519)
  Update Debian from 12.0 to 12.1 (https://www.debian.org/News/2023/20230722) (chef#1517)
  provision.ps1: fixed virtio-win-guest-tools.exe installation (chef#1516)
raykrist pushed a commit to norcams/bento that referenced this pull request Aug 19, 2024
* updates `vmware_guest_os_type` for almalinux and rockylinux 9 aarch64
  to match the vmware hardware profile which reliably results in a
  successful build

Signed-off-by: Dave Rawks <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants