Support YAML 1.2 better #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinow
approved these changes
Sep 23, 2022
| type: | ||
| - type: array | ||
| items: [string, File] | ||
|
|
There was a problem hiding this comment.
Nice. This test appears to contain both options for declaring the values, with and without the ? char 👍
| assertEquals(wkflow.getInputs().get("ncrna_tab_file").getType(), "File?"); | ||
| assertEquals(wkflow.getInputs().get("reverse_reads").getType(), "File?"); | ||
| assertEquals(wkflow.getInputs().get("ssu_tax").getType(), "string, File"); | ||
| assertEquals(wkflow.getInputs().get("rfam_models").getType(), "{type=array, items=[string, File]}"); |
There was a problem hiding this comment.
I think other parts of the file use spaces instead of tabs? (didn't check the whole file, just the parts appearing here in GH UI, above and below your change).
There was a problem hiding this comment.
Ah, I read this test before reading the CWLService change. That file appears to be using tabs. No need to change anything, the project appears to have a mix of both.
There was a problem hiding this comment.
I used the source format option in Eclipse. If you recommend a different formatter then I'll apply that to the entire codebase in a separate PR 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch from snakeyaml to snakeyaml-engine
Motivation and Context
Fix underlying issue in #457 (but does not fix error reporting)
How Has This Been Tested?
The added test fails without the added code.
Screenshots (if appropriate):
Types of changes
Checklist: