Do not panic if windows.layerFolder is null #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsturtevant
force-pushed
the
windows-layer-folders
branch
from
fb26b7f
to
9d966e3
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
- Coverage 24.39% 23.75% -0.64%
==========================================
Files 21 22 +1
Lines 1644 1692 +48
Branches 816 839 +23
==========================================
+ Hits 401 402 +1
- Misses 546 584 +38
- Partials 697 706 +9 |
|
Clippy is not happy with the change, though, but it's unrelated. |
pushed up a fix on 92420be |
|
|
jsturtevant
force-pushed
the
windows-layer-folders
branch
from
92420be
to
0ae6d4e
Compare
ran |
If windows layerFolders in null string then loading of the runtime spec fails. This happens when containerd serializes Windows{} portion of the spec due to the way golang serializes lists. Although the runtime spec says this is a required field, containerd 1.6 and 1.7 do not fill this field resulting in a null value when serialized to disk. See opencontainers/runtime-spec#1185 for discusion of this field in the runtime spec.
Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
force-pushed
the
windows-layer-folders
branch
from
0ae6d4e
to
b8ca149
Compare
|
I dropped the linter commit since #129 merged |
saschagrunert
approved these changes
Apr 28, 2023
utam0k
approved these changes
Apr 30, 2023
|
@jsturtevant Thanks 🙏 |
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If windows layerFolders in
nullstring then loading of the runtime spec fails. This happens when containerd serializesWindows{}portion of the spec due to the way golang serializes lists. Although the runtime spec says this is a required field, containerd 1.6 and 1.7 do not fill this field resulting in a null value when serialized to disk. See opencontainers/runtime-spec#1185 for discussion of this field in the runtime spec.fixes #126