-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not panic if windows.layerFolder is null #127
Conversation
fb26b7f
to
9d966e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
- Coverage 24.39% 23.75% -0.64%
==========================================
Files 21 22 +1
Lines 1644 1692 +48
Branches 816 839 +23
==========================================
+ Hits 401 402 +1
- Misses 546 584 +38
- Partials 697 706 +9 |
Clippy is not happy with the change, though, but it's unrelated. |
pushed up a fix on 92420be |
|
92420be
to
0ae6d4e
Compare
ran |
If windows layerFolders in null string then loading of the runtime spec fails. This happens when containerd serializes Windows{} portion of the spec due to the way golang serializes lists. Although the runtime spec says this is a required field, containerd 1.6 and 1.7 do not fill this field resulting in a null value when serialized to disk. See opencontainers/runtime-spec#1185 for discusion of this field in the runtime spec. Signed-off-by: James Sturtevant <[email protected]>
0ae6d4e
to
b8ca149
Compare
I dropped the linter commit since #129 merged |
@jsturtevant Thanks 🙏 |
If windows layerFolders in
null
string then loading of the runtime spec fails. This happens when containerd serializesWindows{}
portion of the spec due to the way golang serializes lists. Although the runtime spec says this is a required field, containerd 1.6 and 1.7 do not fill this field resulting in a null value when serialized to disk. See opencontainers/runtime-spec#1185 for discussion of this field in the runtime spec.fixes #126