Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings for K8s 1.31 and OCP 4.17. #352

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

donatwork
Copy link
Contributor

Description

Remove warnings from the script installer when on K8s 1.31 and OCP 4.17

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1472
dell/csm#1473

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested installer on K8s 1.31, no warnings about K8s 1.31
  • Tested installer on OCP 4.17, no warnings about OCP 4.17

santhoshatdell
santhoshatdell previously approved these changes Oct 7, 2024
Copy link
Contributor

@santhoshatdell santhoshatdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update the min required version?

@lukeatdell
Copy link
Contributor

Should we also update the min required version?

blame history shows k8s min version hasn't been updated in a while, but it looks like ocp is regularly updated.

dell-csi-helm-installer/verify-csi-powerstore.sh Outdated Show resolved Hide resolved
@donatwork
Copy link
Contributor Author

Should we also update the min required version?

Min versions confirmed and updated.

@donatwork donatwork merged commit 5837fd7 into main Oct 8, 2024
5 checks passed
@donatwork donatwork deleted the 1472-k8s_131_ocp_416_install branch October 8, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants