Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operator Minimal CR feature: Documentation #1273

Merged
merged 11 commits into from
Oct 14, 2024
Merged

Operator Minimal CR feature: Documentation #1273

merged 11 commits into from
Oct 14, 2024

Conversation

ashleyvjoy
Copy link
Contributor

@ashleyvjoy ashleyvjoy commented Oct 8, 2024 •
edited
Loading

Description

Documentation to deploy CSM using Operator minimal CR files

GitHub Issues

List the GitHub issues impacted by this PR:

| GitHub Issue # |
| (dell/csm#1449) |

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?
    image
preview-pflex preview-pmax preview-pstore

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024 •
edited
Loading

Test Results

77 tests  ±0   77 ✅ ±0   3s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit d201fb2. ± Comparison against base commit 39dd74e.

♻️ This comment has been updated with latest results.

@ashleyvjoy ashleyvjoy marked this pull request as ready for review October 10, 2024 09:55
@ashleyvjoy ashleyvjoy changed the title Operator Minimal CR feature: Documentation(WIP) Operator Minimal CR feature: Documentation Oct 10, 2024
rajkumar-palani
rajkumar-palani requested changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@rajkumar-palani rajkumar-palani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please attach the local preview as mentioned in the checklist?

@ashleyvjoy
Copy link
Contributor Author

ashleyvjoy commented Oct 14, 2024 •
edited
Loading

can you please attach the local preview as mentioned in the checklist?

@rajkumar-palani Sure. I've added the images as mentioned in the checklist. Local preview is hosted in my dev VM. We do not mention IPs in public facing repos. I will ping the preview link to you over slack

@rajkumar-palani
Copy link
Collaborator

can you please attach the local preview as mentioned in the checklist?

@rajkumar-palani Sure. I've added the images as mentioned in the checklist. Local preview is hosted in my dev VM. We do not mention IPs in public facing repos. I will ping the preview link to you over slack

Thank You.

rajkumar-palani
rajkumar-palani approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@rajkumar-palani rajkumar-palani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ashleyvjoy ashleyvjoy merged commit c6310d3 into main Oct 14, 2024
7 checks passed
coulof pushed a commit that referenced this pull request Oct 21, 2024
@ashleyvjoy @coulof
Operator Minimal CR feature: Documentation (#1273)
1f066f2 
* minimal CR documentation for drivers

* add modules doc for minimal CR

* update spacing and font size

* add doc changes

* modify documentation

* modify unity md file

* revert last commit to unity md file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harishp8889 harishp8889 harishp8889 approved these changes

@rajkumar-palani rajkumar-palani rajkumar-palani approved these changes

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@AronAtDell AronAtDell Awaiting requested review from AronAtDell AronAtDell is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashleyvjoy @rajkumar-palani @harishp8889