Add support for Observability with minimal manifest #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkshaySainiDell
requested review from
abhi16394,
mbasha-dell,
alikdell,
bharathsreekanth,
chimanjain,
coulof,
Deepak-Ghivari,
gallacher,
gilltaran,
harishp8889 and
HarishH-DELL
as code owners
AkshaySainiDell
requested review from
meggm,
mgandharva,
mjsdell,
nitesh3108,
Prabhu-Dell,
rajendraindukuri,
rajkumar-palani,
shefali-malhotra,
panigs7,
tdawe,
shaynafinocchiaro,
atye,
sharmilarama and
shanmydell
as code owners
AkshaySainiDell
changed the title
AkshaySainiDell
changed the title
suryagupta4
previously approved these changes
Oct 10, 2024
meggm
reviewed
Oct 10, 2024
operatorconfig/moduleconfig/observability/v1.10.0/karavi-metrics-powerflex.yaml
Show resolved
Hide resolved
meggm
previously approved these changes
Oct 10, 2024
adarsh-dell
reviewed
Oct 10, 2024
AkshaySainiDell
dismissed stale reviews from meggm and suryagupta4
via
402cf24
suryagupta4
approved these changes
Oct 10, 2024
meggm
approved these changes
Oct 10, 2024
ChristianAtDell
added a commit
that referenced
this pull request
Oct 15, 2024
* obs minimal manifest * updated changes * Set default components for minimal manifest * Refactor code * Fix default-components.yaml path * Fix for pscale and add minimal obs yaml for pflex * Fix observability deployement error * Fix metrics pod not getting deployed * Revert powerflex v2.11.0 sample yaml * Fix linting failure * powerscale observability changes * yamllint fix * gofumpt fix * Load default components in reconcile method * Update logger * Address review comments * Add loggers --------- Co-authored-by: Kakde <[email protected]> Co-authored-by: Surya Gupta <[email protected]> Co-authored-by: Surya Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for Observability with minimal manifest for PowerFlex and PowerScale driver.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Ran PowerScale with Observability E2E, metrics and topology tests
Ran PowerFlex with Observability E2E, metrics and topology tests