feat: add websocket orderbook example #265
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** I send a new PR to reflect a latest commit **
@yogurtandjam Thank you for applying the convention to the PR title.
Your feedback that the code should be encapsulated to make it easier to read is reasonable.
So I reflected the feedback.
Please let me know if there is anything else that needs to be improved!
When pushing orderbook data, it's better to insert it in the right place to keep the sorted orderbook list than to sort it at the end, but I chose a good read logic because the orderbook list is small and just an example.