Excluding floating-ui portals as part of hiding tooltips in Playwrigh…

…t screenshots (#28287) * Excluding floating-ui portals as part of hiding tooltips in Playwright screenshots Signed-off-by: Michael Telatynski <[email protected]> * Update screenshot Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]>
element-hq · Oct 28, 2024 · 954ff0a · 954ff0a
1 parent ef60526
commit 954ff0a
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 9 deletions.
diff --git a/playwright/e2e/pinned-messages/index.ts b/playwright/e2e/pinned-messages/index.ts
@@ -196,14 +196,7 @@ export class Helpers {
      */
     async assertEmptyPinnedMessagesList() {
         const rightPanel = this.getRightPanel();
-        await expect(rightPanel).toMatchScreenshot(`pinned-messages-list-empty.png`, {
-            // hide the tooltip "Room information" to avoid flakiness
-            css: `
-                [data-floating-ui-portal] {
-                    display: none !important;
-                }
-            `,
-        });
+        await expect(rightPanel).toMatchScreenshot(`pinned-messages-list-empty.png`);
     }
 
     /**

diff --git a/playwright/e2e/release-announcement/index.ts b/playwright/e2e/release-announcement/index.ts
@@ -42,7 +42,7 @@ export class Helpers {
      */
     async assertReleaseAnnouncementIsVisible(name: string) {
         await expect(this.getReleaseAnnouncement(name)).toBeVisible();
-        await expect(this.page).toMatchScreenshot(`release-announcement-${name}.png`);
+        await expect(this.page).toMatchScreenshot(`release-announcement-${name}.png`, { showTooltips: true });
     }
 
     /**

diff --git a/playwright/element-web-test.ts b/playwright/element-web-test.ts
@@ -345,6 +345,7 @@ export const expect = baseExpect.extend({
 
         if (!options?.showTooltips) {
             css += `
+                [data-floating-ui-portal],
                 [role="tooltip"] {
                     visibility: hidden !important;
                 }

diff --git a/...snapshots/threads/threads.spec.ts/Reply-to-the-location-on-ThreadView-linux.png b/...snapshots/threads/threads.spec.ts/Reply-to-the-location-on-ThreadView-linux.png