Remove "Upgrade your encryption" flow in CreateSecretStorageDialog
#28290
+115
−663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/remove-upgrade-encryption
branch
from
4fad3aa
to
b42bae5
Compare
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/remove-upgrade-encryption
branch
from
b42bae5
to
2461c03
Compare
florianduros
requested review from
BillCarsonFr,
t3chguy,
robintown and
richvdh
t3chguy
approved these changes
Oct 25, 2024
richvdh
requested changes
Oct 25, 2024
src/async-components/views/dialogs/security/CreateSecretStorageDialog.tsx
Outdated
Show resolved
Hide resolved
src/async-components/views/dialogs/security/CreateSecretStorageDialog.tsx
Outdated
Show resolved
Hide resolved
test/unit-tests/components/views/dialogs/security/CreateSecretStorageDialog-test.tsx
Outdated
Show resolved
Hide resolved
test/unit-tests/components/views/dialogs/security/CreateSecretStorageDialog-test.tsx
Outdated
Show resolved
Hide resolved
|
I think it should be a separate PR, but note that there is more "upgrade your encryption" stuff in |
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/remove-upgrade-encryption
branch
from
02e111d
to
bdf26a6
Compare
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/remove-upgrade-encryption
branch
from
bdf26a6
to
63a2ef1
Compare
florianduros
changed the title
florianduros
changed the title
CreateSecretStorageDialog
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/remove-upgrade-encryption
branch
from
87f1bc3
to
e0fd3da
Compare
richvdh
approved these changes
Oct 30, 2024
src/async-components/views/dialogs/security/CreateSecretStorageDialog.tsx
Outdated
Show resolved
Hide resolved
…eDialog.tsx Co-authored-by: Richard van der Hoff <[email protected]>
florianduros
deleted the
florianduros/rip-out-legacy-crypto/remove-upgrade-encryption
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.Part of #27455
Task #26922
I'm not familiar with this area of EW, normally I shouldn't have break something.
To be honest, the original tests were... a bit of a mess. I change them to at least go thought the critical path of the component.