docs: forgot to remove completely inherit_optimization

etiennebacher · Sep 28, 2024 · fe02afb · fe02afb
1 parent ce4937a
commit fe02afb
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 46 deletions.
diff --git a/R/sink.R b/R/sink.R
@@ -50,8 +50,6 @@
 #' @param no_optimization Sets the following optimizations to `FALSE`:
 #'   `predicate_pushdown`, `projection_pushdown`,  `slice_pushdown`,
 #'   `simplify_expression`. Default is `FALSE`.
-#' @param inherit_optimization Use existing optimization settings regardless of
-#'   the settings specified in this function call. Default is `FALSE`.
 #'
 #' @return The input LazyFrame.
 #' @export

diff --git a/man/sink_parquet.Rd b/man/sink_parquet.Rd
diff --git a/tests/testthat/test-funs-string.R b/tests/testthat/test-funs-string.R
@@ -121,47 +121,42 @@ test_that("str_trim() works", {
 #   )
 # })
 
+test_that("str_dup() works", {
+  for_all(
+    tests = 40,
+    string = character_(any_na = TRUE),
+    # Very high numbers crash the session, I guess because of stringr
+    times = numeric_bounded(-10000, 10000, any_na = TRUE),
+    property = function(string, times) {
+      test_df <- data.frame(x1 = string)
+      test <- pl$DataFrame(x1 = string)
 
-# TODO: Counter example
-# string = c(NA, NA, NA, NA, "VsF7|'x", "VsF7|'x", NA, "VsF7|'x")
-# times = c(0, 0,  0,  0, NA, NA, NA,  0)
+      expect_equal_or_both_error(
+        mutate(test, foo = str_dup(x1, times = times)) |>
+          pull(foo),
+        mutate(test_df, foo = str_dup(x1, times = times)) |>
+          pull(foo)
+      )
+    }
+  )
+})
 
-# test_that("str_dup() works", {
-#   for_all(
-#     tests = 20,
-#     string = character_(any_na = TRUE),
-#     # Very high numbers crash the session, I guess because of stringr
-#     times = numeric_bounded(-10000, 10000, any_na = TRUE),
-#     property = function(string, times) {
-#       test_df <- data.frame(x1 = string)
-#       test <- pl$DataFrame(x1 = string)
-#
-#       expect_equal_or_both_error(
-#         mutate(test, foo = str_dup(x1, times = times)) |>
-#           pull(foo),
-#         mutate(test_df, foo = str_dup(x1, times = times)) |>
-#           pull(foo)
-#       )
-#     }
-#   )
-# })
+test_that("str_sub() works", {
+  for_all(
+    tests = 40,
+    string = character_(any_na = TRUE),
+    start = numeric_(any_na = TRUE),
+    end = numeric_(any_na = TRUE),
+    property = function(string, start, end) {
+      test_df <- data.frame(x1 = string)
+      test <- pl$DataFrame(x1 = string)
 
-# test_that("str_sub() works", {
-#   for_all(
-#     tests = 40,
-#     string = character_(any_na = TRUE),
-#     start = numeric_(any_na = TRUE),
-#     end = numeric_(any_na = TRUE),
-#     property = function(string, start, end) {
-#       test_df <- data.frame(x1 = string)
-#       test <- pl$DataFrame(x1 = string)
-#
-#       expect_equal_or_both_error(
-#         mutate(test, foo = str_sub(x1, start, end)) |>
-#           pull(foo),
-#         mutate(test_df, foo = str_sub(x1, start, end)) |>
-#           pull(foo)
-#       )
-#     }
-#   )
-# })
+      expect_equal_or_both_error(
+        mutate(test, foo = str_sub(x1, start, end)) |>
+          pull(foo),
+        mutate(test_df, foo = str_sub(x1, start, end)) |>
+          pull(foo)
+      )
+    }
+  )
+})