Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: I believe onError results in destruction of the sink, like how onEOM can/does. HTTPMessageFilters don't detachTransaction(): ``` void onError(const HTTPException& error) noexcept override { nextTransactionHandler_->onError(error); } ``` And, more importantly: Got a segfault when testing in traflab: ``` *** Aborted at 1728517165 (Unix time, try 'date -d 1728517165') *** *** Signal 11 (SIGSEGV) (0x0) received by PID 929 (pthread TID 0x7fafd67ff640) (linux TID 1030) (code: address not mapped to object), stack trace: *** @ 000000000e5e755a folly::symbolizer::(anonymous namespace)::innerSignalHandler(int, siginfo_t*, void*) [clone .__uniq.302291754384189453301783370447166124111] ./fbcode/folly/debugging/symbolizer/SignalHandler.cpp:453 @ 000000000e5e749e folly::symbolizer::(anonymous namespace)::signalHandler(int, siginfo_t*, void*) [clone .__uniq.302291754384189453301783370447166124111] [clone .llvm.12006849344459385367] ./fbcode/folly/debugging/symbolizer/SignalHandler.cpp:474 @ 000000000004455f (unknown) /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/signal/../sysdeps/unix/sysv/linux/libc_sigaction.c:8 -> /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/signal/../sysdeps/unix/sysv/linux/x86_64/libc_sigaction.c @ 0000000011e8046d proxygen::HTTPTunnelSink::readErr(folly::AsyncSocketException const&) ./fbcode/proxygen/lib/http/sink/HTTPTunnelSink.cpp:141 ``` Reviewed By: jalopezsilva Differential Revision: D64148187 fbshipit-source-id: e7970ed1c746a5bc28c15cfcf5950ee7bc79d67c
- Loading branch information