fix: don't hardcode deployment environment in logs #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vacekj
approved these changes
Jul 21, 2023
gravityblast
approved these changes
Jul 21, 2023
To be fair, there should be a single schema instead of scattered validations, but given the risk for breakage I went for the incremental change. The idiomatic version is for the next round. |
bard
added a commit
that referenced
this pull request
Aug 2, 2023
* fix: don't hardcode deployment environment in logs * enh: validate remaining variables and arguments with zod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for deployment to production.
fixes: #176