Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/redundant message #3718

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

eben619
Copy link
Contributor

@eben619 eben619 commented Oct 29, 2024

Fixes: #3604

Description

Conditional rendering of the message on the modal such that it does not display if the networks being checked out in the cart are not more than 1. Even if there are multiple projects in the cart but are on the same network.

Checklist

This PR:

  • Does it add new payout or donation token? In this case, have they been added to the indexer to avoid it to crash?
  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 0:15am
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 0:15am
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 0:15am
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 0:15am
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 0:15am
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 0:15am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redundant message if only one network
1 participant